linux-kernel - Re: [PATCH v6 1/1] PRUSS UIO driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 28 Feb 2011 22:26:38 +0100
From:	"Hans J. Koch" <hjk@...sjkoch.de>
To:	Pratheesh Gangadhar <pratheesh@...com>
Cc:	linux-kernel@...r.kernel.org, hjk@...sjkoch.de, gregkh@...e.de,
	tglx@...utronix.de, sshtylyov@...sta.com, arnd@...db.de,
	amit.chatterjee@...com,
	davinci-linux-open-source@...ux.davincidsp.com,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v6 1/1] PRUSS UIO driver support

On Tue, Mar 01, 2011 at 02:31:35AM +0530, Pratheesh Gangadhar wrote:
> +
> +		/* Register PRUSS IRQ lines */
> +		p->irq = IRQ_DA8XX_EVTOUT0 + cnt;
> +		p->handler = pruss_handler;
> +
> +		ret = uio_register_device(&dev->dev, p);
> +
> +		if (ret < 0)
> +			goto out_free;
> +	}
> +
> +	spin_lock_init(&lock);

That's too late. uio_register_device() enables the irq, and your spin_lock
is not ready at that time.

> +	platform_set_drvdata(dev, info);
> +	return 0;
> +
> +out_free:
> +	pruss_cleanup(dev, info);
> +	return ret;
> +}

Thanks,
Hans

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/