linux-kernel - Re: [PATCH] x86, ioapic: move acpi_get_override

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 1 Apr 2011 18:26:53 +0200
From:	Florian Mickler <florian@...kler.org>
To:	mingo@...e.hu
Cc:	linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org,
	Len Brown <lenb@...nel.org>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	kurup_avinash@...oo.com, maciej.rutecki@...il.com, rjw@...k.pl,
	sedat.dilek@...il.com
Subject: Re: [PATCH] x86, ioapic: move acpi_get_override_irq to acpi.c

On Fri,  1 Apr 2011 17:44:46 +0200
Florian Mickler <florian@...kler.org> wrote:


> 
> Hi Ingo,
> 
> Instead of exporting find_irq_entry, irq_trigger and irq_polarity, I added a 
> new helper function 'ioapic_get_irq(..)' and exported that. 
> 
> Also I did it as a seperate commit, since it is more of a cleanup and the other 
> commit is already tested... hope this is ok. 
> 
> Regards,
> Flo
> 

btw, include/linux/acpi.h:
120 
121 #ifdef CONFIG_X86_IO_APIC
122 extern int acpi_get_override_irq(u32 gsi, int *trigger, int *polarity);
123 #else
124 #define acpi_get_override_irq(gsi, trigger, polarity) (-1)
125 #endif

this shouldn't be needed anymore, as acpi_get_override_irq is now
independent of CONFIG_X86_IO_APIC (because of ioapic_get_irq having
a placeholder in the !CONFIG_X86_IO_APIC case)

But on the other hand, the code flow for the !CONFIG_X86_IO_APIC would
be kind of silly...  what's the rationale for mp_find_ioapic returning
0 in the !CONFIG_X86_IO_APIC case? And how do I check compilation
of !CONFIG_X86_IO_APIC?   It looks like it already has problems, as
mp_find_ioapic_pin is not stubbed out, or am I overlooking something?

Regards,
Flo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/