[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 06 Jun 2011 10:31:23 +0100
From: Jonathan Cameron <jic23@....ac.uk>
To: Greg Dietsche <Gregory.Dietsche@....edu>
CC: perex@...ex.cz, tiwai@...e.de, broonie@...nsource.wolfsonmicro.com,
dp@...nsource.wolfsonmicro.com, lrg@...com,
alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] wm8940: remove unecessary if statement
On 06/06/11 01:47, Greg Dietsche wrote:
> the code always returns ret regardless, so if(ret) check is unecessary.
Good point, though please spell check your commit messages.
unecessary -> unnecessary
Also if you want to do this sort of cleanup, please also fix the
equivalent in wm8940_resume and wm8940_add_widgets. Ack is for
what is here, plus those if you do them.
Just as an aside, there is no earthly point in cc'ing lkml for a
simple cleanup like this. Just adds to already huge amount of noise!
>
> Signed-off-by: Greg Dietsche <Gregory.Dietsche@....edu>
Acked-by: Jonathan Cameron <jic23@....ac.uk>
> ---
> sound/soc/codecs/wm8940.c | 3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/sound/soc/codecs/wm8940.c b/sound/soc/codecs/wm8940.c
> index 25580e3..1ada6d3 100644
> --- a/sound/soc/codecs/wm8940.c
> +++ b/sound/soc/codecs/wm8940.c
> @@ -730,9 +730,6 @@ static int wm8940_probe(struct snd_soc_codec *codec)
> if (ret)
> return ret;
> ret = wm8940_add_widgets(codec);
> - if (ret)
> - return ret;
> -
> return ret;
> }
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists