| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 6 Jun 2011 10:51:58 +0100 From: Liam Girdwood <lrg@...com> To: Greg Dietsche <Gregory.Dietsche@....edu> CC: Jonathan Cameron <jic23@....ac.uk>, "perex@...ex.cz" <perex@...ex.cz>, "tiwai@...e.de" <tiwai@...e.de>, "broonie@...nsource.wolfsonmicro.com" <broonie@...nsource.wolfsonmicro.com>, "dp@...nsource.wolfsonmicro.com" <dp@...nsource.wolfsonmicro.com>, "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] wm8940: remove unecessary if statement On 06/06/11 10:31, Jonathan Cameron wrote: > On 06/06/11 01:47, Greg Dietsche wrote: >> the code always returns ret regardless, so if(ret) check is unecessary. > Good point, though please spell check your commit messages. > unecessary -> unnecessary > > Also if you want to do this sort of cleanup, please also fix the > equivalent in wm8940_resume and wm8940_add_widgets. Ack is for > what is here, plus those if you do them. > > Just as an aside, there is no earthly point in cc'ing lkml for a > simple cleanup like this. Just adds to already huge amount of noise! >> >> Signed-off-by: Greg Dietsche <Gregory.Dietsche@....edu> > Acked-by: Jonathan Cameron <jic23@....ac.uk> Acked-by: Liam Girdwood <lrg@...com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists