linux-kernel - Re: [PATCH] wm8940: remove unecessary if statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 06 Jun 2011 07:45:47 -0500
From:	Greg Dietsche <gregory.dietsche@....edu>
To:	Jonathan Cameron <jic23@....ac.uk>
CC:	perex@...ex.cz, tiwai@...e.de, broonie@...nsource.wolfsonmicro.com,
	dp@...nsource.wolfsonmicro.com, lrg@...com,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] wm8940: remove unecessary if statement

Hi Jonathan,

On 06/06/2011 04:31 AM, Jonathan Cameron wrote:
> On 06/06/11 01:47, Greg Dietsche wrote:
>    
>> the code always returns ret regardless, so if(ret) check is unecessary.
>>      
> Good point, though please spell check your commit messages.
> unecessary ->  unnecessary
>    
oops! usually I'm the guy critiquing spelling :)
> Also if you want to do this sort of cleanup, please also fix the
> equivalent in wm8940_resume and wm8940_add_widgets.  Ack is for
> what is here, plus those if you do them.
>    
I will take a look at these, but it might be a few days. I used 
coccinelle to create this patch and my semantic patch wasn't 'smart' 
enough to find them.
> Just as an aside, there is no earthly point in cc'ing lkml for a
> simple cleanup like this. Just adds to already huge amount of noise!
>    
Thanks for all of your feedback. In your opinion, what is the best way 
for someone such as myself to send patches like these? I read in 
Documentation/SubmittingPatches "Unless you have a reason NOT to do so, 
CC linux-kernel@...r.kernel.org"

Also, for this embarrassing spelling problem... do I submit a new patch? :)

Thanks,
Greg

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/