linux-kernel - Re: [PATCH v3] usb: add new usb gadget for ACM and mass storage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 10 Oct 2011 18:00:11 +0200
From:	"Michal Nazarewicz" <mina86@...a86.com>
To:	balbi@...com, "Klaus Schwarzkopf" <schwarzkopf@...sortherm.de>
Cc:	gregkh@...e.de, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, sshtylyov@...mvista.com
Subject: Re: [PATCH v3] usb: add new usb gadget for ACM and mass storage

On Mon, 10 Oct 2011 10:33:01 +0200, Klaus Schwarzkopf <schwarzkopf@...sortherm.de> wrote:
>> +static struct usb_device_descriptor device_desc = {
>> +	.bLength =		sizeof device_desc,
>> +	.bDescriptorType =	USB_DT_DEVICE,
>> +
>> +	.bcdUSB =		cpu_to_le16(0x0200),
>> +
>> +	.bDeviceClass =		USB_CLASS_COMM,
>> +	.bDeviceSubClass =	0,
>> +	.bDeviceProtocol =	0,

> Should bDeviceClass, bDeviceSubClass, and bDeviceProtocol have the same
> value like in the file multi.c?
>
> 	.bDeviceClass =		USB_CLASS_MISC /* 0xEF */,
> 	.bDeviceSubClass =	2,
> 	.bDeviceProtocol =	1,

IIRC, the reason multi.c has those is because Windows does not recognise
a multi-configuration device with zeros here.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/