linux-kernel - Re: REGRESSION: "perf: Add PM notifiers ..." breaks resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 3 Nov 2011 08:37:25 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Andi Kleen <andi@...stfloor.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	linux-kernel@...r.kernel.org, rjw@...k.pl
Subject: Re: REGRESSION: "perf: Add PM notifiers ..." breaks resume

* Linus Torvalds <torvalds@...ux-foundation.org> wrote:

> Peter, Ingo, ping?
> 
> Quite frankly, I'm inclined to revert that patch just for being 
> horribly ugly and apparently broken regardless of the fact that it 
> also causes a regression.
> 
> *Notifiers* for doing something like this? smp_call_function? 
> That's just utter sh*t, guys.
> 
> If it is CPU state, then it should damn well be suspended and 
> resumed as part of CPU suspend and resume. No IPI cross-calls to 
> ask other CPU's to do random work, no crap like that.

Agreed, that's quite crappy.

> Comments? Should I just revert the thing (silence is obviously 
> "yes" in cases like this where we are talking about regressions 
> anyway)?

Yep, please revert it until we do the right fix. (I can queue up the 
revert too)

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/