linux-kernel - Re: [PATCH] blackfin: Fixup export.h includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 11 Nov 2011 10:53:53 -0500
From:	Paul Gortmaker <paul.gortmaker@...driver.com>
To:	Bob Liu <lliubbo@...il.com>
CC:	Lars-Peter Clausen <lars@...afoo.de>,
	Mike Frysinger <vapier@...too.org>,
	Sonic Zhang <sonic.zhang@...log.com>,
	<uclinux-dist-devel@...ckfin.uclinux.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] blackfin: Fixup export.h includes

On 11-11-11 05:54 AM, Bob Liu wrote:
> On Fri, Nov 11, 2011 at 6:06 PM, Lars-Peter Clausen <lars@...afoo.de> wrote:
>> Commit 8dc7a9c84 ("blackfin: Add export.h to files using
>> EXPORT_SYMBOL/THIS_MODULE") inserted some of the include statements into
>> sections protected by an unrelated #if CONFIG_... statement. This can cause,
>> depending on the configuration used, warnings like this one:
>>
>>        arch/blackfin/mach-bf537/boards/stamp.c:2940: warning: data definition has no type or storage class
>>        arch/blackfin/mach-bf537/boards/stamp.c:2940: warning: type defaults to ‘int’ in declaration of ‘EXPORT_SYMBOL’
>>        arch/blackfin/mach-bf537/boards/stamp.c:2940: warning: parameter names (without types) in function declaration
>>
>> This patch fixes it by moving the includes out of the #if protected sections.
>>
>> Signed-off-by: Lars-Peter Clausen <lars@...afoo.de>

[...]

>>
> 
> Thanks!  I'll pick it.
> 
> Acked-by: Bob Liu <lliubbo@...il.com>

Looks fine to me as well.  I'm assuming it will make it in
tree via Bob, as per above.

Thanks,
Paul.

> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/