linux-kernel - [PATCH] perf: Fix implicit declaration of getline in util/probe-finder.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Fri, 11 Nov 2011 09:48:47 -0600
From:	Josh Hunt <johunt@...mai.com>
To:	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>, Ingo Molnar <mingo@...e.hu>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
Cc:	linux-kernel@...r.kernel.org
Subject: [PATCH] perf: Fix implicit declaration of getline in util/probe-finder.c

On my older build machine I get the following failure:

CC util/probe-finder.o
cc1: warnings being treated as errors
util/probe-finder.c: In function 'find_lazy_match_lines':
util/probe-finder.c:864: warning: implicit declaration of function 'getline'
util/probe-finder.c:864: warning: nested extern declaration of 'getline'
make: *** [util/probe-finder.o] Error 1

This is a similar problem to the one resolved with git commit: 69e3f52d.
As with that fix I'm using util.h to provide the necessary inclusions as well
as handling _GNU_SOURCE.

Signed-off-by: Josh Hunt <johunt@...mai.com>
---
 tools/perf/util/probe-finder.c |   12 +-----------
 1 files changed, 1 insertions(+), 11 deletions(-)

diff --git a/tools/perf/util/probe-finder.c b/tools/perf/util/probe-finder.c
index 5d73262..0f33926 100644
--- a/tools/perf/util/probe-finder.c
+++ b/tools/perf/util/probe-finder.c
@@ -19,24 +19,14 @@
  *
  */
 
+#include "util.h"
 #include <sys/utsname.h>
-#include <sys/types.h>
-#include <sys/stat.h>
-#include <fcntl.h>
-#include <errno.h>
-#include <stdio.h>
-#include <unistd.h>
 #include <getopt.h>
-#include <stdlib.h>
-#include <string.h>
-#include <stdarg.h>
-#include <ctype.h>
 #include <dwarf-regs.h>
 
 #include <linux/bitops.h>
 #include "event.h"
 #include "debug.h"
-#include "util.h"
 #include "symbol.h"
 #include "probe-finder.h"
 
-- 
1.7.0.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/