linux-kernel - Re: [RFC v2] cdc-acm: Fix potential deadlock (lockdep warning)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 28 Nov 2011 10:15:16 -0800
From:	Havard Skinnemoen <hskinnemoen@...gle.com>
To:	Alan Cox <alan@...ux.intel.com>, Jiri Slaby <jslaby@...e.cz>,
	Oliver Neukum <oliver@...kum.org>
Cc:	Dave Jones <davej@...hat.com>, Greg Kroah-Hartman <gregkh@...e.de>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Havard Skinnemoen <hskinnemoen@...gle.com>
Subject: Re: [RFC v2] cdc-acm: Fix potential deadlock (lockdep warning)

On Sun, Nov 27, 2011 at 1:37 PM, Havard Skinnemoen
<hskinnemoen@...gle.com> wrote:
> -       if (0 > acm_set_control(acm, acm->ctrlout = ACM_CTRL_DTR | ACM_CTRL_RTS) &&
> +       acm->ctrlout = ACM_CTRL_DTR | ACM_CTRL_RTS;
> +       if (acm_set_control(acm, acm->ctrlout < 0) &&

Ok, so this is obviously broken. Unfortunately, my test setup doesn't
use the control signals in any way.

I'm sure I broke something else, so I'm going to wait a bit for others
to have a look before I post an updated patch.

Havard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/