linux-kernel - Re: [PATCH 3/7] mfd: twl4030-irq: drop the kthread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 12 Dec 2011 19:48:41 +0200
From:	Felipe Contreras <felipe.contreras@...il.com>
To:	Felipe Balbi <balbi@...com>
Cc:	Linux OMAP Mailing List <linux-omap@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Tony Lindgren <tony@...mide.com>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 3/7] mfd: twl4030-irq: drop the kthread

On Thu, Jun 30, 2011 at 12:51 PM, Felipe Balbi <balbi@...com> wrote:
> ... and use threaded IRQ infrastructure. Later
> patches will come dropping both workqueues and
> setting the nested thread flag.

...

>  static irqreturn_t handle_twl4030_pih(int irq, void *devid)
>  {
> -       /* Acknowledge, clear *AND* mask the interrupt... */
> -       disable_irq_nosync(irq);
> -       complete(devid);

...

> -       status = request_irq(irq_num, handle_twl4030_pih, IRQF_DISABLED,
> -                               "TWL4030-PIH", &irq_event);
> +       status = request_threaded_irq(irq_num, NULL, handle_twl4030_pih,
> +                       IRQF_DISABLED, "TWL4030-PIH", NULL);

FTR, in this reorganization this code was dropped
disable_irq_nosync(irq), which means the irq's would never be cleared.
IRQF_ONESHOT should have been on the flags.

But Neil Brown already found the issue and fixed it :)
http://article.gmane.org/gmane.linux.kernel/1220705

-- 
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/