linux-kernel - Re: Staging: bcm: Don't leak 'pstAddIndication' in CmHost.c::StoreCmControlResponseMessage()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 12 Feb 2012 00:54:31 +0100 (CET)
From:	Jesper Juhl <jj@...osbits.net>
To:	Greg KH <gregkh@...uxfoundation.org>
cc:	linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
	"Justin P. Mattock" <justinmattock@...il.com>,
	Ilia Mirkin <imirkin@...m.mit.edu>,
	Lucas De Marchi <lucas.demarchi@...fusion.mobi>
Subject: Re: Staging: bcm: Don't leak 'pstAddIndication' in
 CmHost.c::StoreCmControlResponseMessage()

On Fri, 10 Feb 2012, Greg KH wrote:

> On Thu, Feb 09, 2012 at 11:33:25PM +0100, Jesper Juhl wrote:
> > From: Jesper Juhl <jj@...esealer.com>
> > 
> > We allocate memory for 'pstAddIndication' with kmalloc() in
> > drivers/staging/bcm/CmHost.c::StoreCmControlResponseMessage() and then
> > neglect to free it on a number of exit paths from that function.
> > 
> > This could probably be resolved cleaner/nicer, but this file needs a
> > serious overhaul in any case, so I opted for just fixing the problem
> > as directly as I could and then we can clean it up generally
> > later... This at least makes it stop bleeding..
> > 
> > Signed-off-by: Jesper Juhl <jj@...esealer.com>
> 
> Odd, didn't I already apply this patch?
> 
> confused,
> 

Well, you were the one who (in email message with Message-ID: 
<20120209175217.GA13959@...ah.com>) said that it no longer applied and 
asked for a resubmit against linux-next:

  "This patch no longer applies, care to redo it against the latest
  linux-next tree?"

So I just did what you asked :-)

Whether or not you have already applied it somewhere else I have no 
idea...

-- 
Jesper Juhl <jj@...osbits.net>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/