linux-kernel - Re: Staging: bcm: Don't leak 'pstAddIndication' in CmHost.c::StoreCmControlResponseMessage()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 13 Feb 2012 20:05:46 -0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Jesper Juhl <jj@...osbits.net>
Cc:	linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
	"Justin P. Mattock" <justinmattock@...il.com>,
	Ilia Mirkin <imirkin@...m.mit.edu>,
	Lucas De Marchi <lucas.demarchi@...fusion.mobi>
Subject: Re: Staging: bcm: Don't leak 'pstAddIndication' in
 CmHost.c::StoreCmControlResponseMessage()

On Sun, Feb 12, 2012 at 12:54:31AM +0100, Jesper Juhl wrote:
> On Fri, 10 Feb 2012, Greg KH wrote:
> 
> > On Thu, Feb 09, 2012 at 11:33:25PM +0100, Jesper Juhl wrote:
> > > From: Jesper Juhl <jj@...esealer.com>
> > > 
> > > We allocate memory for 'pstAddIndication' with kmalloc() in
> > > drivers/staging/bcm/CmHost.c::StoreCmControlResponseMessage() and then
> > > neglect to free it on a number of exit paths from that function.
> > > 
> > > This could probably be resolved cleaner/nicer, but this file needs a
> > > serious overhaul in any case, so I opted for just fixing the problem
> > > as directly as I could and then we can clean it up generally
> > > later... This at least makes it stop bleeding..
> > > 
> > > Signed-off-by: Jesper Juhl <jj@...esealer.com>
> > 
> > Odd, didn't I already apply this patch?
> > 
> > confused,
> > 
> 
> Well, you were the one who (in email message with Message-ID: 
> <20120209175217.GA13959@...ah.com>) said that it no longer applied and 
> asked for a resubmit against linux-next:
> 
>   "This patch no longer applies, care to redo it against the latest
>   linux-next tree?"
> 
> So I just did what you asked :-)

Yes, but...

> Whether or not you have already applied it somewhere else I have no 
> idea...

I tried to apply this, and it said it was already applied.  So either I
already merged it, or someone else made the same patch, or you created
it reverted.

I'm confused, sorry.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/