linux-kernel - Re: [PATCH] sysctl: fix write access to dmesg_restrict/kptr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 04 Apr 2012 21:07:03 +0200
From:	Richard Weinberger <richard@....at>
To:	Kees Cook <keescook@...omium.org>
CC:	"Serge E. Hallyn" <serge@...lyn.com>, linux-kernel@...r.kernel.org,
	PhillipLougherplougher@...hat.com,
	Andrew Morton <akpm@...ux-foundation.org>,
	Greg Kroah-Hartman <greg@...ah.com>,
	Dan Rosenberg <drosenberg@...curity.com>,
	Eugene Teo <eteo@...hat.com>, Eric Paris <eparis@...hat.com>,
	James Morris <jmorris@...ei.org>
Subject: Re: [PATCH] sysctl: fix write access to dmesg_restrict/kptr_restrict

On 04.04.2012 20:40, Kees Cook wrote:
> Commit bfdc0b4 adds code to restrict access to dmesg_restrict,
> however, it incorrectly alters kptr_restrict rather than
> dmesg_restrict.
>
> The original patch from Richard Weinberger
> (https://lkml.org/lkml/2011/3/14/362) alters dmesg_restrict as
> expected, and so the patch seems to have been misapplied.
>
> This adds the CAP_SYS_ADMIN check to both dmesg_restrict and
> kptr_restrict, since both are sensitive.
>
> Reported-by: Phillip Lougher<plougher@...hat.com>
> Signed-off-by: Kees Cook<keescook@...omium.org>
> Cc: stable@...r.kernel.org

Acked-by: Richard Weinberger <richard@....at>

Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/