linux-kernel - Re: Fix bug in end absolute address in drivers/mtd/devices/slram.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 22 Sep 2012 11:14:16 +0200
From:	Roel Kluin <roel.kluin@...il.com>
To:	Jiri Kosina <jkosina@...e.cz>
Cc:	Jiri Engelthaler <engycz@...il.com>, linux-kernel@...r.kernel.org,
	David Woodhouse <dwmw2@...radead.org>
Subject: Re: Fix bug in end absolute address in drivers/mtd/devices/slram.c

On Thu, Sep 20, 2012 at 5:55 PM, Jiri Kosina <jkosina@...e.cz> wrote:
> On Thu, 20 Sep 2012, Jiri Engelthaler wrote:
>
>> Hello.
>>   I found a bug in parsing end absolute address in
>> drivers/mtd/devices/slram.c. There is checking for startaddress <
>> endaddress and endaddress subtracted by startaddress before check. The
>> bug is there from commit 3afd522de8d8ec446efe957b86e4f63e3dd8ce9d Mon,
>> 19 Jan 2009 01:24:21 +0000
>>
>> Here is the patch
>>
>> Signed-off-by: Jiri Engelthaler <engycz@...il.com>
>>
>> --- linux-3.2.28/drivers/mtd/devices/slram.c  2012-08-19 19:15:38.000000000 +0200
>> +++ linux-3.2.28.mod/drivers/mtd/devices/slram.c      2012-09-19
>> 18:29:28.012740703 +0200
>> @@ -266,7 +266,7 @@ static int parse_cmdline(char *devname,
>>
>>       if (*(szlength) != '+') {
>>               devlength = simple_strtoul(szlength, &buffer, 0);
>> -             devlength = handle_unit(devlength, buffer) - devstart;
>> +             devlength = handle_unit(devlength, buffer);
>>               if (devlength < devstart)
>>                       goto err_out;
>
> ... adding the suspects to CC so that they are aware of this.

Yes, that's what it should have been. FWIW,

Acked-by: Roel Kluin <roel.kluin@...il.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/