| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 16 Nov 2012 19:09:14 +0200 From: Johan Meiring <johanmeiring@...il.com> To: Greg KH <gregkh@...uxfoundation.org> Cc: pe1dnn@...at.org, jkosina@...e.cz, standby24x7@...il.com, viro@...iv.linux.org.uk, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 3/3] staging: wlags49_h2: mdd.h: fixes tons of coding style issues Will do. Just a quick question: Is it acceptable to submit small patches even if the main file still fails the checkpatch,pl script? i.e. is it OK to fix e.g. the first 20 instances of C99 // comment usage, even if 200 remain afterwards, and then fix them later? Johan On 16 November 2012 19:06, Greg KH <gregkh@...uxfoundation.org> wrote: > On Fri, Nov 16, 2012 at 06:55:11PM +0200, Johan Meiring wrote: >> This commit sorts out a ton of styling issues, including the use of >> C99 // comments, spaces before and after tabs, etc. I also took the >> time to align stuff a little more neatly using tabs. The file is >> nowhere near ready, but it's a start. >> >> Signed-off-by: Johan Meiring <johanmeiring@...il.com> >> --- >> drivers/staging/wlags49_h2/mdd.h | 1593 +++++++++++++++++++------------------- >> 1 file changed, 797 insertions(+), 796 deletions(-) > > A patch this big is almost impossible to review, sorry. Please break it > up into smaller pieces. > > thanks, > > greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists