linux-kernel - Re: [PATCH] MFD: ab8500: pass AB8500 IRQ to debugfs code by resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 12 Apr 2013 15:43:52 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Linus Walleij <linus.walleij@...ricsson.com>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Anmar Oueja <anmar.oueja@...aro.org>,
	Lee Jones <lee.jones@...aro.org>,
	Rickard ANDERSSON <rickard.andersson@...ricsson.com>
Subject: Re: [PATCH] MFD: ab8500: pass AB8500 IRQ to debugfs code by resource

On Fri, Apr 12, 2013 at 12:48 PM, Arnd Bergmann <arnd@...db.de> wrote:
> On Friday 12 April 2013, Linus Walleij wrote:
>> On Fri, Apr 12, 2013 at 10:08 AM, Arnd Bergmann <arnd@...db.de> wrote:
>> > On Friday 12 April 2013, Linus Walleij wrote:
>>
>> >> Actually, well, this one IRQ (the one I start to pass) is already
>> >> domain-mapped to the global IRQ numberspace, so that one will
>> >> be correct.
>> >
>> > I don't know if we're talking about the same thing here.
>> >
>> > My point was that passing a domain-mapped IRQ number into mfd_add_devices
>> > with another domain will result in the attempt to map that number into
>> > another domain, which does not work.
>>
>> Ah, yes you're right ... now I need to find some other way
>> to pass this resource ... hm.
>
> What is it actually needed for? In the code I'm looking at in linux-next
> it only gets passed to a function that ignores it.

Well that is a __attribute((weak)) function. It is overridden
by suspend/resume code in the machine to ask the suspend
code whether the AB8500 woke the system up.

Arguably not such a nice design :-/

However that suspend code is being posted to the linux-pm
mailinglist as we speak, so I don't want to make their life
miserable by just deleting some hook they're actually using
for testing.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/