linux-kernel - Re: sched: add notifier for cross-cpu migrations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 10 Jul 2013 16:39:02 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	mtosatti@...hat.com, mingo@...hat.com, gleb@...hat.com,
	glommer@...allels.com, tglx@...utronix.de, jeremy@...p.org,
	rostedt@...dmis.org, linux-kernel@...r.kernel.org
Subject: Re: sched: add notifier for cross-cpu migrations


* Peter Zijlstra <peterz@...radead.org> wrote:

> Hi,
> 
> I just stumbled over commit 582b336ec2 and had a massive WTF moment.
> 
> The Changelog -- empty!
> The Implementation -- complete crap!
> 
> fail^2.
> 
> A git grep later I find its x86_64 paravirt only.. for this we add 
> unconditional crap to the scheduler?
> 
> At the _very_ least this should have been wrapped in a static_key and 
> the changelog should have given some clue as to the what and why of this 
> code.

My bad for letting it slip through...

Marcelo, mind implementing the suggestions from Peter?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/