linux-kernel - Re: [PATCH 3/3] driver: input: twl6040-vibra: fix missing of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 1 Sep 2013 19:59:58 +0300
From:	Peter Ujfalusi <peter.ujfalusi@...com>
To:	Libo Chen <clbchenlibo.chen@...wei.com>
CC:	<dmitry.torokhov@...il.com>, Bill Pemberton <wfp5p@...ginia.edu>,
	<broonie@...nsource.wolfsonmicro.com>, <javier@...hile0.org>,
	<linux-input@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>,
	Li Zefan <lizefan@...wei.com>,
	"zhangwei(Jovi)" <jovi.zhangwei@...wei.com>
Subject: Re: [PATCH 3/3] driver: input: twl6040-vibra: fix missing of_node_put

On 08/31/2013 09:45 AM, Libo Chen wrote:
> 
> decrease twl6040_core_node device_node refcount after task completion
> 
> There are two ways to implement the function of_node_put through
> the marco CONFIG_OF_DYNAMIC, so it is save to call directly.
> 
> Signed-off-by: Libo Chen <libo.chen@...wei.com>

Acked-by: Peter Ujfalusi <peter.ujfalusi@...com>

> ---
>  drivers/input/misc/twl6040-vibra.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/input/misc/twl6040-vibra.c b/drivers/input/misc/twl6040-vibra.c
> index 0c2dfc8..f16193a 100644
> --- a/drivers/input/misc/twl6040-vibra.c
> +++ b/drivers/input/misc/twl6040-vibra.c
> @@ -271,12 +271,14 @@ static int twl6040_vibra_probe(struct platform_device *pdev)
>  #endif
> 
>  	if (!pdata && !twl6040_core_node) {
> +		of_node_put(twl6040_core_node);
>  		dev_err(&pdev->dev, "platform_data not available\n");
>  		return -EINVAL;
>  	}
> 
>  	info = devm_kzalloc(&pdev->dev, sizeof(*info), GFP_KERNEL);
>  	if (!info) {
> +		of_node_put(twl6040_core_node);
>  		dev_err(&pdev->dev, "couldn't allocate memory\n");
>  		return -ENOMEM;
>  	}
> @@ -304,6 +306,7 @@ static int twl6040_vibra_probe(struct platform_device *pdev)
>  				     &vddvibl_uV);
>  		of_property_read_u32(twl6040_core_node, "ti,vddvibr-uV",
>  				     &vddvibr_uV);
> +		of_node_put(twl6040_core_node);
>  	}
> 
>  	if ((!info->vibldrv_res && !info->viblmotor_res) ||
> 


-- 
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/