linux-kernel - Re: [PATCH 2/3] driver: input: twl4030-vibra: fix missing of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 1 Sep 2013 20:01:31 +0300
From:	Peter Ujfalusi <peter.ujfalusi@...com>
To:	Libo Chen <clbchenlibo.chen@...wei.com>
CC:	<dmitry.torokhov@...il.com>, Bill Pemberton <wfp5p@...ginia.edu>,
	<broonie@...nsource.wolfsonmicro.com>,
	<linux-input@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] driver: input: twl4030-vibra: fix missing of_node_put

On 08/31/2013 09:45 AM, Libo Chen wrote:
> 
> decrease node device_node refcount after task completion
> 
> Signed-off-by: Libo Chen <libo.chen@...wei.com>

Acked-by: Peter Ujfalusi <peter.ujfalusi@...com>

> ---
>  drivers/input/misc/twl4030-vibra.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/input/misc/twl4030-vibra.c b/drivers/input/misc/twl4030-vibra.c
> index 68a5f33..b8d1526 100644
> --- a/drivers/input/misc/twl4030-vibra.c
> +++ b/drivers/input/misc/twl4030-vibra.c
> @@ -185,8 +185,10 @@ static bool twl4030_vibra_check_coexist(struct twl4030_vibra_data *pdata,
>  	if (pdata && pdata->coexist)
>  		return true;
> 
> -	if (of_find_node_by_name(node, "codec"))
> +	if (of_find_node_by_name(node, "codec")) {
> +		of_node_put(node);
>  		return true;
> +	}
> 
>  	return false;
>  }
> 


-- 
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/