lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 6 Dec 2013 14:52:07 +0000 From: Christoph Lameter <cl@...ux.com> To: Joonsoo Kim <iamjoonsoo.kim@....com> cc: Andrew Morton <akpm@...ux-foundation.org>, Mel Gorman <mgorman@...e.de>, Rik van Riel <riel@...hat.com>, Rafael Aquini <aquini@...hat.com>, Naoya Horiguchi <n-horiguchi@...jp.nec.com>, Joonsoo Kim <js1304@...il.com>, linux-kernel@...r.kernel.org, linux-mm@...ck.org Subject: Re: [PATCH 1/4] mm/migrate: correct return value of migrate_pages() On Fri, 6 Dec 2013, Joonsoo Kim wrote: > migrate_pages() should return number of pages not migrated or error code. > When unmap_and_move return -EAGAIN, outer loop is re-execution without > initialising nr_failed. This makes nr_failed over-counted. > > So this patch correct it by initialising nr_failed in outer loop. Well nr_retry is the total number of attempts that got EGAIN. nr_failed is the total number of failed attempts. You are making nr_failed the number of pages of the list that have failed to migrated. That syncs with the description. > diff --git a/mm/migrate.c b/mm/migrate.c > index 3747fcd..1f59ccc 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -1102,6 +1102,7 @@ int migrate_pages(struct list_head *from, new_page_t get_new_page, > > for(pass = 0; pass < 10 && retry; pass++) { > retry = 0; > + nr_failed = 0; The initialization of nr_failed and retry earlier is then useless. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists