linux-kernel - Re: [PATCH 3/3] ASoC: fsl: imx-wm8962: Add headphone and microphone jack plugin/out detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 6 Dec 2013 15:03:19 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Nicolin Chen <b42378@...escale.com>
Cc:	lgirdwood@...il.com, alsa-devel@...a-project.org, tiwai@...e.de,
	perex@...ex.cz, linux-kernel@...r.kernel.org,
	linux-doc@...r.kernel.org, devicetree@...r.kernel.org,
	rob@...dley.net, ijc+devicetree@...lion.org.uk,
	swarren@...dotorg.org, mark.rutland@....com, pawel.moll@....com,
	rob.herring@...xeda.com
Subject: Re: [PATCH 3/3] ASoC: fsl: imx-wm8962: Add headphone and microphone
 jack plugin/out detection

On Fri, Dec 06, 2013 at 10:38:17PM +0800, Nicolin Chen wrote:
> On Fri, Dec 06, 2013 at 02:42:56PM +0000, Mark Brown wrote:

> > What's this uevent trying to do and why is it open coded in the driver?

> That's a requirement from Android team of Freescale. By checking this
> event they can determine whether current output is speaker or headphone
> so as to place an icon on the notification area.

> Sir, if you think this patch is not common enough or non-community style,
> I can try to cut it down to an common one or entirely drop it.

This isn't mainline stuff, this is the Android standard switch class.
Someone should really contribute something to Android which backs it
onto the back of ALSA jacks.  The mainline equivalent is extcon which
does have switch class emulation but it's a bit broken in its generation
of uevents and is also not yet integrated into the ALSA jack stuff.

The thing to do is ideally integrate extcon with the ALSA jack code and
update the Android headset observer to work with extcon (or write a
separate extcon based observer).

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)