linux-kernel - Re: [PATCH] drivers: staging: lustre: lustre: include: add "__attribute_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 18 Jan 2014 18:26:10 +0800
From:	Chen Gang <gang.chen.5i5j@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
CC:	Greg KH <gregkh@...uxfoundation.org>, andreas.dilger@...el.com,
	bergwolf@...il.com, jinshan.xiong@...el.com, oleg.drokin@...el.com,
	jacques-charles.lafoucriere@....fr, devel@...verdev.osuosl.org,
	James Hogan <james.hogan@...tec.com>,
	linux-metag@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drivers: staging: lustre: lustre: include: add "__attribute__((packed))"
 for the related union

On 01/18/2014 06:05 PM, Dan Carpenter wrote:
> On Sat, Jan 18, 2014 at 05:50:34PM +0800, Chen Gang wrote:
>> Unfortunately, not all compilers assumes the structures within a pack
>> region also need be packed (e.g. metag), so need add a pack explicitly
>> to satisfy all compilers.
>>
>> The related error (under metag with allmodconfig):
>>
>>     CC [M]  drivers/staging/lustre/lustre/lov/lov_pack.o
>>   drivers/staging/lustre/lustre/lov/lov_pack.c: In function 'lov_getstripe':
>>   drivers/staging/lustre/lustre/lov/lov_pack.c:630: error: duplicate case value
>>   drivers/staging/lustre/lustre/lov/lov_pack.c:630: error: previously used here
>>
>> And originally, all related code used "__attribute__((packed))", so
>> still use it instead of '__packed'.
> 
> Use __packed.  Then at least one line will be correct which is better
> than nothing.
> 

Hmm... but that will break the 'consistency' (which is not quite good
for readers).

For me, it will be better to provide another patch to change all
"__attribute__((packed))" to "__packed" within this file.

What about your ideas?


Thanks.
-- 
Chen Gang

Open, share and attitude like air, water and life which God blessed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/