linux-kernel - Re: [PATCH 3/3] perf trace: Decode architecture-specific signal numbers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 09 Mar 2014 13:55:33 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Ingo Molnar <mingo@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH 3/3] perf trace: Decode architecture-specific signal
 numbers

What's happening with this patch?  perf fails to build on alpha or sparc
since 3.13.

Ben.

On Thu, 2014-02-06 at 01:00 +0000, Ben Hutchings wrote:
> SIGSTKFLT is not defined on alpha, mips or sparc.
> SIGEMT and SIGSWI are defined on some architectures and should be
> decoded here if so.
> 
> Fixes: 8bad5b0abfdb ('perf trace: Beautify signal number arg in several syscalls')
> Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
> Cc: <stable@...r.kernel.org>
> ---
>  tools/perf/builtin-trace.c | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
> index 5c32dcf..25ea64c 100644
> --- a/tools/perf/builtin-trace.c
> +++ b/tools/perf/builtin-trace.c
> @@ -807,7 +807,6 @@ static size_t syscall_arg__scnprintf_signum(char *bf, size_t size, struct syscal
>  	P_SIGNUM(PIPE);
>  	P_SIGNUM(ALRM);
>  	P_SIGNUM(TERM);
> -	P_SIGNUM(STKFLT);
>  	P_SIGNUM(CHLD);
>  	P_SIGNUM(CONT);
>  	P_SIGNUM(STOP);
> @@ -823,6 +822,15 @@ static size_t syscall_arg__scnprintf_signum(char *bf, size_t size, struct syscal
>  	P_SIGNUM(IO);
>  	P_SIGNUM(PWR);
>  	P_SIGNUM(SYS);
> +#ifdef SIGEMT
> +	P_SIGNUM(EMT);
> +#endif
> +#ifdef SIGSTKFLT
> +	P_SIGNUM(STKFLT);
> +#endif
> +#ifdef SIGSWI
> +	P_SIGNUM(SWI);
> +#endif
>  	default: break;
>  	}
>  
> 

-- 
Ben Hutchings
I say we take off; nuke the site from orbit.  It's the only way to be sure.

Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)