linux-kernel - Re: [PATCHv3 2/4] ACPI / LPSS: custom power domain for LPSS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 26 May 2014 16:42:34 +0300
From:	Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:	"Rafael J. Wysocki" <rjw@...ysocki.net>
Cc:	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	Jin Yao <yao.jin@...ux.intel.com>,
	Li Aubrey <aubrey.li@...ux.intel.com>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCHv3 2/4] ACPI / LPSS: custom power domain for LPSS

On Mon, May 26, 2014 at 03:03:27PM +0200, Rafael J. Wysocki wrote:
> On Friday, May 23, 2014 04:15:09 PM Heikki Krogerus wrote:
> > A power domain where we save the context of the additional
> > LPSS registers. We need to do this or all LPSS devices are
> > left in reset state when resuming from D3 on some Baytrails.
> > The devices with the fractional clock divider also have
> > zeros for N and M values after resuming unless they are
> > reset.
> > 
> > Li Aubrey found the root cause for the issue. The idea of
> > using power domain for LPSS came from Mika Westerberg.
> > 
> > Reported-by: Jin Yao <yao.jin@...ux.intel.com>
> > Suggested-by: Li Aubrey <aubrey.li@...ux.intel.com>
> > Tested-by: Mika Westerberg <mika.westerberg@...ux.intel.com>
> > Signed-off-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> 
> Queued up for 3.16, but I needed to rebase it to take some other changes
> into account.  Can you please have a look and the bleeding-edge branch in
> my tree and see if everything looks good in there?

I checked the bleeding-edge and it looks good to me. Thanks for taking
care of the issue with "%lx".

About the sparse warning from the clk-fractional-divider.c. Since
there is no real issue, let's follow the style in the other clock
types and ignore the warning. So let's keep that patch as it is. OK?



-- 
heikki
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/