linux-kernel - [PATCH] sched: Remove synchronize rcu/sched calls from _cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 25 Jul 2014 17:26:08 +0530
From:	Kaushal Kumar <kaushalk@...eaurora.org>
To:	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...nel.org>,
	Michael Wang <wangyun@...ux.vnet.ibm.com>,
	Arun Bharadwaj <abharadw@...eaurora.org>
Cc:	linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
	Kaushal Kumar <kaushalk@...eaurora.org>
Subject: [PATCH] sched: Remove synchronize rcu/sched calls from _cpu_down

synchronize_rcu calls fail hot-unplug latency tests since
wait_rcu_gp can have very high latency, at times up to few
hundred of millisecs.

These calls were earlier removed for the same reason by the
commit 9ee349ad6d326df3633d43f54202427295999c47, but got added
back as part of commit c4575f83b9fe87bb57b737bc8a667f746a20320a.

Moreover there should be no need for sync_sched() in _cpu_down
as stop_machine() provides that barrier implicitly.

Signed-off-by: Kaushal Kumar <kaushalk@...eaurora.org>
---
 kernel/cpu.c | 20 --------------------
 1 file changed, 20 deletions(-)

diff --git a/kernel/cpu.c b/kernel/cpu.c
index 887eb32..93e526c 100644
--- a/kernel/cpu.c
+++ b/kernel/cpu.c
@@ -311,28 +311,8 @@ static int __ref _cpu_down(unsigned int cpu, int tasks_frozen)
 				__func__, cpu);
 		goto out_release;
 	}
-
-	/*
-	 * By now we've cleared cpu_active_mask, wait for all preempt-disabled
-	 * and RCU users of this state to go away such that all new such users
-	 * will observe it.
-	 *
-	 * For CONFIG_PREEMPT we have preemptible RCU and its sync_rcu() might
-	 * not imply sync_sched(), so explicitly call both.
-	 *
-	 * Do sync before park smpboot threads to take care the rcu boost case.
-	 */
-#ifdef CONFIG_PREEMPT
-	synchronize_sched();
-#endif
-	synchronize_rcu();
-
 	smpboot_park_threads(cpu);

-	/*
-	 * So now all preempt/rcu users must observe !cpu_active().
-	 */
-
 	err = __stop_machine(take_cpu_down, &tcd_param, cpumask_of(cpu));
 	if (err) {
 		/* CPU didn't die: tell everyone.  Can't complain. */
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/