linux-kernel - Re: [RFC] usb issue on imx27: 3 clocks are needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 18 Aug 2014 17:26:37 +0800
From:	Shawn Guo <shawn.guo@...escale.com>
To:	Peter Chen <peter.chen@...escale.com>
CC:	Philippe Reynes <tremyfr@...il.com>,
	<Linux-kernel@...r.kernel.org>, <linux-usb@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	<gwenhael.goavec-merou@...bucayre.com>
Subject: Re: [RFC] usb issue on imx27: 3 clocks are needed

On Mon, Aug 18, 2014 at 05:00:59PM +0800, Peter Chen wrote:
> On Sat, Aug 16, 2014 at 05:38:30PM +0200, Philippe Reynes wrote:
> > Hi all,
> > 
> > i.MX27's usb needs three clocks (usb_ipg_gate, usb_ahb_gate and usb_div)
> > but the current chipidea driver implementation, and devicetree, provides
> > only ipg and ahb. Consequently, if the bootloader don't enable the last
> > one, the kernel will crash.
> > 
> > Our approach/idea is to add a second, optionnal, clock in ci_hdrc_imx.c
> > with 'per' name in devicetree  and to add  clock name 'main_clk' for mandatory clock.
> > This approach it correct? Or an other approach seems better?
> > Thank you very much for your point of view.
> > 
> 
> It is ok for me to have ipg, ahb and per clocks at driver, but how can you maintain
> DT consistent?

Adding new clock as optional one will just maintain the DT
compatibility.

> Can you accept open ipg and per always on at clock.c?

No, usb driver should manage its clocks.

Shawn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/