linux-kernel - Re: [PATCH] powerpc: Wire up sys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 21 Dec 2014 20:56:04 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Pranith Kumar <bobby.prani@...il.com>
Cc:	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Paul Mackerras <paulus@...ba.org>,
	Michael Ellerman <mpe@...erman.id.au>,
	Anton Blanchard <anton@...ba.org>,
	David Herrmann <dh.herrmann@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Fabian Frederick <fabf@...net.be>,
	linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] powerpc: Wire up sys_execveat() syscall

Hi Pranith,

On Sat, 20 Dec 2014 11:47:18 -0500 Pranith Kumar <bobby.prani@...il.com> wrote:
>
> Wire up sys_execveat(). This passes the selftests for the system call.

Thanks for this, but ...

> diff --git a/arch/powerpc/include/asm/systbl.h b/arch/powerpc/include/asm/systbl.h
> index ce9577d..778844a 100644
> --- a/arch/powerpc/include/asm/systbl.h
> +++ b/arch/powerpc/include/asm/systbl.h
> @@ -366,3 +366,4 @@ SYSCALL_SPU(seccomp)
>  SYSCALL_SPU(getrandom)
>  SYSCALL_SPU(memfd_create)
>  SYSCALL_SPU(bpf)
> +SYSCALL_SPU(execveat)

Given that it passes pointers into the kernel and looking at the execve
system call, I assume that it should be COMPAT_SYS().

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au

Content of type "application/pgp-signature" skipped