linux-kernel - Re: [PATCH] staging: vt6655: fix sparse warning: argument type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 21 Dec 2014 10:17:17 +0000
From:	Malcolm Priestley <tvboxspy@...il.com>
To:	Jeremiah Mahler <jmmahler@...il.com>,
	Eddie Kovsky <ewk@...ovsky.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: vt6655: fix sparse warning: argument type

On 21/12/14 08:17, Jeremiah Mahler wrote:
> Eddie, all,
>
> On Sat, Dec 20, 2014 at 10:27:55PM -0700, Eddie Kovsky wrote:
>> Fixes following warning generated by sparse:
>>
>> drivers/staging/vt6655/baseband.c:2180:45: warning: incorrect type in argument 1 (different address spaces)
>> drivers/staging/vt6655/baseband.c:2180:45:    expected struct vnt_private *priv
>> drivers/staging/vt6655/baseband.c:2180:45:    got void [noderef] <asn:2>*dwIoBase
>>
>> Compile tested on next-20141219.
>>
>> Signed-off-by: Eddie Kovsky <ewk@...ovsky.org>
>> ---
>>   drivers/staging/vt6655/baseband.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/baseband.c
>> index 86c72ba0a0cd..f8c5fc371c4c 100644
>> --- a/drivers/staging/vt6655/baseband.c
>> +++ b/drivers/staging/vt6655/baseband.c
>> @@ -2177,7 +2177,7 @@ bool BBbVT3253Init(struct vnt_private *priv)
>>   		/* Init ANT B select,RX Config CR10 = 0x28->0x2A, 0x2A->0x28(VC1/VC2 define, make the ANT_A, ANT_B inverted) */
>>   		/*bResult &= BBbWriteEmbedded(dwIoBase,0x0a,0x28);*/
>>   		/* Select VC1/VC2, CR215 = 0x02->0x06 */
>> -		bResult &= BBbWriteEmbedded(dwIoBase, 0xd7, 0x06);
>> +		bResult &= BBbWriteEmbedded(priv, 0xd7, 0x06);
>>   		/* }} */
>>
>>   		for (ii = 0; ii < CB_VT3253B0_AGC; ii++)
> [...]
>
> The change looks right.  BBbWriteEmbedded use priv to get dwIoBase.
> And every other call to BBbWriteEmbedded uses the priv argument.
>
>     dwIoBase = priv->PortOffset;
>
> So how did this mistake get in there?
>
> It looks like it was simply missed in commit 377f5bc00f7e1.  All the
> ones before and after were changed, but not this one.
Yes it was missed probably because it looks like it commented out.

Good catch Eddie.

As my device does not this baseband type I won't encounter the bug.

Greg, this needs to go into 3.19.

Thanks

Malcolm

>
> Interestingly, if you go back to this commit and compile it, no error
> is generated unless you enable sparse checks.
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/