linux-kernel - Re: [PATCH v2] ARM: pxa: fix pxa interrupts handling in DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 02 Feb 2015 21:22:01 +0100
From:	Robert Jarzmik <robert.jarzmik@...e.fr>
To:	Daniel Mack <daniel@...que.org>,
	Haojian Zhuang <haojian.zhuang@...il.com>
Cc:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] ARM: pxa: fix pxa interrupts handling in DT

Robert Jarzmik <robert.jarzmik@...e.fr> writes:

> @@ -66,18 +67,20 @@ static inline void __iomem *irq_base(int i)
>  void pxa_mask_irq(struct irq_data *d)
>  {
>  	void __iomem *base = irq_data_get_irq_chip_data(d);
> +	irq_hw_number_t irq = irqd_to_hwirq(d);
>  	uint32_t icmr = __raw_readl(base + ICMR);
>  
> -	icmr &= ~(1 << IRQ_BIT(d->irq));
> +	icmr &= ~BIT(irq);
This should be : icmr &= ~BIT(irq & 0x1f);

>  	__raw_writel(icmr, base + ICMR);
>  }
>  
>  void pxa_unmask_irq(struct irq_data *d)
>  {
>  	void __iomem *base = irq_data_get_irq_chip_data(d);
> +	irq_hw_number_t irq = irqd_to_hwirq(d);
>  	uint32_t icmr = __raw_readl(base + ICMR);
>  
> -	icmr |= 1 << IRQ_BIT(d->irq);
> +	icmr |= BIT(irq);
Ditto.

> +void __init pxa_init_irq(int irq_nr, int (*fn)(struct irq_data *, unsigned int))
> +{
> +	BUG_ON(irq_nr > MAX_INTERNAL_IRQS);
> +
> +	pxa_irq_base = io_p2v(0x40d00000);
> +	cpu_has_ipr = !cpu_is_pxa25x();
> +	pxa_init_irq_common(NULL, irq_nr, fn);
> +}
This requires "select IRQ_DOMAIN" in arch/arm/Kconfig in ARCH_PXA.

-- 
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/