linux-kernel - Re: [PATCH] spi: fsl-dspi: Remove possible memory leak of 'chip'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 2 Feb 2015 20:23:56 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Bhuvanchandra DV <bhuvanchandra.dv@...adex.com>, stefan@...er.ch,
	linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spi: fsl-dspi: Remove possible memory leak of 'chip'

On Sat, Jan 31, 2015 at 07:46:48PM +0300, Dan Carpenter wrote:
> On Sat, Jan 31, 2015 at 10:03:25PM +0530, Bhuvanchandra DV wrote:
> > Move the check for spi->bits_per_word
> > before allocation, to avoid memory leak.

> > Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

> Normally, you would give me a Reported-by: tag.  Not a big deal either
> way.

It is a big deal - the Signed-off-by involves all the stuff in
SubmittingPatches which means that you really shouldn't add a signoff
for anyone who didn't supply one.  I've changed to a Reported-by and
applied, please be more careful with this in future Bhuvanchandra.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)