linux-kernel - [PATCH] scsi: eata: fix sparse warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Date:	Thu,  5 Feb 2015 12:21:57 +0000
From:	Lad Prabhakar <prabhakar.csengg@...il.com>
To:	"James E.J. Bottomley" <JBottomley@...allels.com>,
	linux-scsi@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org,
	"Lad, Prabhakar" <prabhakar.csengg@...il.com>
Subject: [PATCH] scsi: eata: fix sparse warning

From: "Lad, Prabhakar" <prabhakar.csengg@...il.com>

this patch fixes following sparse warning:

eata.c:2049:5: warning: symbol 'eata2x_bios_param' was not declared. Should it be static?

Signed-off-by: Lad, Prabhakar <prabhakar.csengg@...il.com>
---
 Found this issue on linux-next (gcc  version 4.9.2,
 sparse version  0.4.5-rc1)and applies on top linux-next.

 drivers/scsi/eata.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/eata.c b/drivers/scsi/eata.c
index 227dd2c..e178325 100644
--- a/drivers/scsi/eata.c
+++ b/drivers/scsi/eata.c
@@ -2046,8 +2046,9 @@ static int eata2x_eh_host_reset(struct scsi_cmnd *SCarg)
 	return SUCCESS;
 }
 
-int eata2x_bios_param(struct scsi_device *sdev, struct block_device *bdev,
-		      sector_t capacity, int *dkinfo)
+static int
+eata2x_bios_param(struct scsi_device *sdev, struct block_device *bdev,
+		  sector_t capacity, int *dkinfo)
 {
 	unsigned int size = capacity;
 
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/