linux-kernel - Re: [PATCH 2/3] iio: qcom-spmi-iadc: cleanup wait_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 05 Feb 2015 14:23:11 +0200
From:	"Ivan T. Ivanov" <iivanov@...sol.com>
To:	Jonathan Cameron <jic23@...nel.org>
Cc:	Nicholas Mc Guire <hofrat@...dl.org>,
	Hartmut Knaack <knaack.h@....de>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Peter Meerwald <pmeerw@...erw.net>, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] iio: qcom-spmi-iadc: cleanup wait_for_completion
 return handling


On Wed, 2015-02-04 at 16:59 +0000, Jonathan Cameron wrote:
> On 02/02/15 08:37, Nicholas Mc Guire wrote:
> > This patch fixes two issues:
> > * return type of wait_for_completion_timeout is unsigned long not int,
> >   rather than adding a dedicated variable the wait_for_completion_timeout
> >   is moved into the condition directly
> > * the timeout of wait_for_completion_timeout is in jiffies but the value
> >   being passed was a unsigned long not converted to jiffies and thus was
> >   dependent on the HZ settings which is probably not what you want.
> > 
> > Signed-off-by: Nicholas Mc Guire <hofrat@...dl.org>
> Ivan, need your Ack / Reviewed-by on this one.
> 

Yes, change is correct, as explained before [1].

Acked-by: Ivan T. Ivanov <iivanov@...sol.com>


[1] https://lkml.org/lkml/2015/1/5/409

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/