linux-kernel - Re: [PATCH 30/60] mtd: nand: fsl_elbc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 10 Mar 2015 08:42:43 +0100
From:	Frans Klaver <fransklaver@...il.com>
To:	Brian Norris <computersforpeace@...il.com>
Cc:	David Woodhouse <dwmw2@...radead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-mtd@...ts.infradead.org
Subject: Re: [PATCH 30/60] mtd: nand: fsl_elbc_nand: show device in sysfs

On Tue, Mar 10, 2015 at 7:28 AM, Brian Norris
<computersforpeace@...il.com> wrote:
> On Tue, Mar 03, 2015 at 10:40:14PM +0100, Frans Klaver wrote:
>> Fix a bug where devices aren't shown in sysfs.
>>
>> While at it, make use of the default owner value set by mtdcore.
>>
>> Signed-off-by: Frans Klaver <fransklaver@...il.com>
>> ---
>>  drivers/mtd/nand/fsl_elbc_nand.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mtd/nand/fsl_elbc_nand.c b/drivers/mtd/nand/fsl_elbc_nand.c
>> index 04b22fd..0cd94a1 100644
>> --- a/drivers/mtd/nand/fsl_elbc_nand.c
>> +++ b/drivers/mtd/nand/fsl_elbc_nand.c
>> @@ -747,7 +747,7 @@ static int fsl_elbc_chip_init(struct fsl_elbc_mtd *priv)
>>
>>       /* Fill in fsl_elbc_mtd structure */
>>       priv->mtd.priv = chip;
>> -     priv->mtd.owner = THIS_MODULE;
>> +     priv->mtd.dev.parent = &chip->dev;
>
> drivers/mtd/nand/fsl_elbc_nand.c: In function 'fsl_elbc_chip_init':
> drivers/mtd/nand/fsl_elbc_nand.c:750:30: error: 'struct nand_chip' has no member named 'dev'
> make[4]: *** [drivers/mtd/nand/fsl_elbc_nand.o] Error 1

Thanks for building this. I thought this might happen even though I
spent quite some time trying to prevent it. This should probably have
been

+ priv->mtd.dev.parent = priv->dev;

Off to go find out what other configs & targets to build for.

Thanks,
Frans
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/