linux-kernel - Re: [PATCH 01/60] mtd: core: tone down suggestion that dev.parent should be set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 10 Mar 2015 08:47:46 +0100
From:	Frans Klaver <fransklaver@...il.com>
To:	Brian Norris <computersforpeace@...il.com>
Cc:	David Woodhouse <dwmw2@...radead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-mtd@...ts.infradead.org
Subject: Re: [PATCH 01/60] mtd: core: tone down suggestion that dev.parent
 should be set

On Tue, Mar 10, 2015 at 12:14 AM, Brian Norris
<computersforpeace@...il.com> wrote:
> On Tue, Mar 03, 2015 at 10:39:45PM +0100, Frans Klaver wrote:
>> add_mtd_device() has a comment suggesting that the caller should have
>> set dev.parent. This is required to have the device show up in sysfs,
>
> What do you mean "have the device show up in sysfs"? AFAICT, this only
> has bearing on whether the *parent* device shows up as a sysfs symlink
> within the MTD device directory. i.e.:
>
>    /sys/class/mtd/mtd*/device
>
> For instance, this sort of symlink:
>
>    /sys/class/mtd/mtd0/device -> ../../../f03e2800.nand
>
> It might be good to clarify this in the commit message, since you make
> the problem sound worse than (I think) it is.

I do? That was definitely not my intention. I'll look into it.

Thanks,
Frans
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/