linux-kernel - Re: [PATCH 2/2] spi: bcm-mspi: Add support for Broadcom MSPI driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 14 May 2015 11:31:44 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Scott Branden <sbranden@...adcom.com>
Cc:	Jonathan Richardson <jonathar@...adcom.com>,
	Dmitry Torokhov <dtor@...gle.com>,
	Anatol Pomazau <anatol@...gle.com>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	linux-kernel@...r.kernel.org, linux-spi@...r.kernel.org,
	bcm-kernel-feedback-list <bcm-kernel-feedback-list@...adcom.com>,
	devicetree@...r.kernel.org
Subject: Re: [PATCH 2/2] spi: bcm-mspi: Add support for Broadcom MSPI driver.

On Wed, May 13, 2015 at 05:19:06PM -0700, Scott Branden wrote:

> The purpose of this mspi interface is to connect to NOR flash.  There are
> other SPI interfaces on the devices used to connect to other SPI devies.  We
> don't have any need to support full duplex slaves on this port (NOR have any
> hardware wired this way - pun realized after typing this).

Chip vendors often say this sort of thing and then get surprised by what
their users choose to do, and even if it only ever gets used with flash
all it would take is some new flash command which can use full duplex
for something.  Please write the code so it at least tries to handle
full duplex operation, if you can't test it fully that's not the end of
the world.  It doesn't look like it should be particularly difficult.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)