linux-kernel - Re: [PATCH] staging: unisys: use schedule_timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 31 May 2015 10:18:04 +0900
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Nicholas Mc Guire <hofrat@...dl.org>
Cc:	Benjamin Romer <benjamin.romer@...sys.com>,
	Prarit Bhargava <prarit@...hat.com>,
	devel@...verdev.osuosl.org, sparmaintainer@...sys.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: unisys: use schedule_timeout_interruptible()

On Fri, May 29, 2015 at 05:31:16PM +0200, Nicholas Mc Guire wrote:
> API consolidation with coccinelle found:
> ./drivers/staging/unisys/visorbus/periodic_work.c:196:3-19:
>         consolidation with schedule_timeout_*() recommended
> 
> This is a 1:1 conversion with respect to schedule_timeout() to the 
> schedule_timeout_interruptible() helper only - so only an API 
> consolidation to improve readability. The hard coded timeout of 10
> jiffies is HZ dependent which it should not be, so it is converted
> with msecs_to_jiffies.
> 
> Patch was compile tested with x86_64_defconfig + CONFIG_STAGING=y,
> CONFIG_UNISYSSPAR=y, CONFIG_UNISYS_VISORBUS=m
> 
> Patch is against 4.1-rc5 (localversion-next is -next-20150529)
> 
> Signed-off-by: Nicholas Mc Guire <hofrat@...dl.org>
> ---
> 
> As the actually intended timeout is not documented and msecs_to_jiffies
> timeouts can be a factor 10 different from the current effective timeout
> this needs to be checked by someone who knows the details of this driver
> in any case it should be passed in a HZ independent manner.

I need an ack from the maintainers before I can take this.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/