linux-kernel - Re: [PATCH v2 24/25] arch: remove ioremap_wt, replace with arch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 27 Jul 2015 10:03:48 +0200
From:	Christoph Hellwig <hch@....de>
To:	Dan Williams <dan.j.williams@...el.com>
Cc:	tglx@...utronix.de, mingo@...nel.org, hpa@...or.com,
	linux-arch@...r.kernel.org, Tony Luck <tony.luck@...el.com>,
	toshi.kani@...com, Arnd Bergmann <arnd@...db.de>,
	linux-nvdimm@...ts.01.org, linux-kernel@...r.kernel.org,
	Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
	rmk+kernel@....linux.org.uk, hch@....de,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 24/25] arch: remove ioremap_wt, replace with
	arch_memremap

> +++ b/arch/frv/include/asm/io.h
> @@ -17,8 +17,6 @@
>  
>  #ifdef __KERNEL__
>  
> -#define ARCH_HAS_IOREMAP_WT
> -
>  #include <linux/types.h>
>  #include <asm/virtconvert.h>
>  #include <asm/string.h>
> @@ -267,20 +265,17 @@ static inline void __iomem *ioremap_nocache(unsigned long physaddr, unsigned lon
>  	return __ioremap(physaddr, size, IOMAP_NOCACHE_SER);
>  }
>  
> -static inline void __iomem *ioremap_wt(unsigned long physaddr, unsigned long size)
> -{
> -	return __ioremap(physaddr, size, IOMAP_WRITETHROUGH);
> -}
> -
> -static inline void __iomem *ioremap_fullcache(unsigned long physaddr, unsigned long size)
> -{
> -	return __ioremap(physaddr, size, IOMAP_FULL_CACHING);
> -}


> +void *arch_memremap(resource_size_t offset, size_t size, unsigned long flags)
> +{
> +	return (void *) offset;
> +}
> +EXPORT_SYMBOL(arch_memremap);

This doesn't look like a correct replacement.

Also shouldn't the replacements of ioremap_fullcache or ioremap_wc be
in the previous patch?

A few more similar issues pop up for other architectures as well.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/