linux-kernel - Re: PCIe regression with DRA7xx in 4.4-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 24 Nov 2015 17:48:28 +0530
From:	Kishon Vijay Abraham I <kishon@...com>
To:	Gabriele Paoloni <gabriele.paoloni@...wei.com>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	"james.morse@....com" <james.morse@....com>,
	"gabriel.fernandez@...com" <gabriel.fernandez@...com>,
	"Minghuan.Lian@...escale.com" <Minghuan.Lian@...escale.com>,
	"Wangzhou (B)" <wangzhou1@...ilicon.com>,
	"arnd@...db.de" <arnd@...db.de>,
	"bhelgaas@...gle.com" <bhelgaas@...gle.com>,
	"pratyush.anand@...il.com" <pratyush.anand@...il.com>,
	"Nori, Sekhar" <nsekhar@...com>,
	"jingoohan1@...il.com" <jingoohan1@...il.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: PCIe regression with DRA7xx in 4.4-rc1

Hi,

On Tuesday 24 November 2015 05:38 PM, Gabriele Paoloni wrote:
> Hi Kishon
> 
>> -----Original Message-----
>> From: Kishon Vijay Abraham I [mailto:kishon@...com]
>> Sent: 24 November 2015 12:01
>> To: linux-pci@...r.kernel.org; linux-kernel@...r.kernel.org; linux-
>> omap@...r.kernel.org; james.morse@....com; gabriel.fernandez@...com;
>> Minghuan.Lian@...escale.com; Wangzhou (B); Gabriele Paoloni; arnd@...db.de;
>> bhelgaas@...gle.com; pratyush.anand@...il.com; Nori, Sekhar;
>> jingoohan1@...il.com; linux-arm-kernel@...ts.infradead.org
>> Subject: PCIe regression with DRA7xx in 4.4-rc1
>>
>> Hi,
>>
>> I'm seeing a regression with <d1b9cf31252e905ad563b9e863fd4470f6c3dd1c>("PCI:
>> designware: Make driver arch-agnostic").
>>
>> Logs using a SATA PCIe card [1]. The PCIe card enumerates fine but after that
>> I
>> observe "ata3.00: qc timeout (cmd 0xec), ata3.00: failed to IDENTIFY (I/O
>> error, err_mask=0x4)"
>>
> 
> May this be related to the bug flagged in:
> 
> [PATCH] PCI: designware: remove wrong io_base assignment
> 
> [...]
> diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c
> index 540f077c37ea..02a7452bdf23 100644
> --- a/drivers/pci/host/pcie-designware.c
> +++ b/drivers/pci/host/pcie-designware.c
> @@ -440,7 +440,6 @@ int dw_pcie_host_init(struct pcie_port *pp)
>  					 ret, pp->io);
>  				continue;
>  			}
> -			pp->io_base = pp->io->start;
>  			break;
>  		case IORESOURCE_MEM:
>  			pp->mem = win->res;
> 


yes, this indeed solved the bug.

Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/