linux-kernel - Re: [PATCH v7 3/3] add support for DWC UFS Host Controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 12 Feb 2016 17:52:08 +0000
From:	Joao Pinto <Joao.Pinto@...opsys.com>
To:	Rob Herring <robh@...nel.org>, Joao Pinto <Joao.Pinto@...opsys.com>
CC:	<vinholikatti@...il.com>, <julian.calaby@...il.com>,
	<akinobu.mita@...il.com>, <hch@...radead.org>, <arnd@...db.de>,
	<mark.rutland@....com>, <gbroner@...eaurora.org>,
	<subhashj@...eaurora.org>, <CARLOS.PALMINHA@...opsys.com>,
	<ijc+devicetree@...lion.org.uk>, <linux-kernel@...r.kernel.org>,
	<linux-scsi@...r.kernel.org>, <devicetree@...r.kernel.org>
Subject: Re: [PATCH v7 3/3] add support for DWC UFS Host Controller

Hi Rob,

On 2/12/2016 4:36 PM, Rob Herring wrote:
> On Thu, Feb 11, 2016 at 12:13:06PM +0000, Joao Pinto wrote:
>> +Required properties:
>> +- compatible        : compatible string ("snps,ufshcd-1.0", "snps,ufshcd-1.1"
>> +  or "snps,ufshcd-2.0")
> 
> History has taught us this needs to have a vendor specific compatible 
> string as well. Don't necessarily have to define it now, but just state 
> a vendor string is needed too.

The compatibility string already as the "snps" which is the acronym for Synopsys
which is the HW Controller vendor. Isn't this enough?

> 
>> +- reg               : <registers mapping>
>> +- interrupts        : <interrupt mapping for UFS host controller IRQ>
>> +
>> +Example:
>> +	ufs@...0000000 {
>> +		compatible = "snps,ufshcd-2.0";
>> +		reg = < 0xd0000000 0x10000 >;
>> +		interrupts = < 24 >;
>> +	};

Thanks,
Joao