linux-kernel - Re: [PATCH v7 3/3] add support for DWC UFS Host Controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 12 Feb 2016 13:36:39 -0600
From:	Rob Herring <robh@...nel.org>
To:	Joao Pinto <Joao.Pinto@...opsys.com>
Cc:	vinayak holikatti <vinholikatti@...il.com>,
	julian.calaby@...il.com, Akinobu Mita <akinobu.mita@...il.com>,
	hch@...radead.org, Arnd Bergmann <arnd@...db.de>,
	Mark Rutland <mark.rutland@....com>,
	Gilad Broner <gbroner@...eaurora.org>,
	Subhash Jadavani <subhashj@...eaurora.org>,
	CARLOS.PALMINHA@...opsys.com,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-scsi@...r.kernel.org,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH v7 3/3] add support for DWC UFS Host Controller

On Fri, Feb 12, 2016 at 11:52 AM, Joao Pinto <Joao.Pinto@...opsys.com> wrote:
> Hi Rob,
>
> On 2/12/2016 4:36 PM, Rob Herring wrote:
>> On Thu, Feb 11, 2016 at 12:13:06PM +0000, Joao Pinto wrote:
>>> +Required properties:
>>> +- compatible        : compatible string ("snps,ufshcd-1.0", "snps,ufshcd-1.1"
>>> +  or "snps,ufshcd-2.0")
>>
>> History has taught us this needs to have a vendor specific compatible
>> string as well. Don't necessarily have to define it now, but just state
>> a vendor string is needed too.
>
> The compatibility string already as the "snps" which is the acronym for Synopsys
> which is the HW Controller vendor. Isn't this enough?

Go look drivers for any licensed IP: DW PCIe, DW GMAC, USB EHCI
controllers (pretty much all licensed IP), etc. They all have
variations either from versions of the IP, configuration of the IP,
"enhancements" by the licensee, integration quirks, or all of the
above.

Rob