linux-kernel - Re: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 2 Mar 2016 16:08:33 -0800
From:	Matt Longnecker <mlongnecker@...dia.com>
To:	Wei Ni <wni@...dia.com>, <thierry.reding@...il.com>,
	<rui.zhang@...el.com>, <mikko.perttunen@...si.fi>
CC:	<swarren@...dotorg.org>, <linux-tegra@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature



On 03/01/2016 11:40 PM, Wei Ni wrote:
> >diff --git a/drivers/thermal/tegra_soctherm.c b/drivers/thermal/tegra_soctherm.c
> >index 74ea5765938b..136975220c92 100644
> >--- a/drivers/thermal/tegra_soctherm.c
> >+++ b/drivers/thermal/tegra_soctherm.c
> >@@ -57,7 +57,7 @@
> >  #define READBACK_VALUE_MASK			0xff00
> >  #define READBACK_VALUE_SHIFT			8
> >  #define READBACK_ADD_HALF			BIT(7)
> >-#define READBACK_NEGATE				BIT(1)
> >+#define READBACK_NEGATE				BIT(0)
I confirm that this change is technically correct. It fixes a bug.