linux-kernel - Re: [RFC PATCH 4/4] pinctrl: Parse GpioInt/GpioIo resources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 4 Apr 2016 16:47:40 +0300
From:	Mika Westerberg <mika.westerberg@...ux.intel.com>
To:	Irina Tirdea <irina.tirdea@...el.com>
Cc:	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Len Brown <lenb@...nel.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	linux-gpio@...r.kernel.org, linux-acpi@...r.kernel.org,
	Rob Herring <robh+dt@...nel.org>,
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Octavian Purdila <octavian.purdila@...el.com>,
	Cristina Ciocan <cristina.ciocan@...el.com>,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 4/4] pinctrl: Parse GpioInt/GpioIo resources

On Thu, Mar 31, 2016 at 02:44:45PM +0300, Irina Tirdea wrote:
> +static int acpi_parse_gpio_res(struct pinctrl *p,
> +			       struct pinctrl_map **map,
> +			       unsigned *num_maps,
> +			       struct pinctrl_dev ***pctldevs)
> +{
> +	struct acpi_gpio_lookup lookup;
> +	struct list_head res_list;
> +	struct acpi_device *adev;
> +	unsigned int index;
> +	int ret;
> +
> +	adev = ACPI_COMPANION(p->dev);
> +
> +	*map = NULL;
> +	*num_maps = 0;
> +	memset(&lookup, 0, sizeof(lookup));
> +
> +	/* Parse all GpioInt/GpioIo resources in _CRS and extract pin conf */
> +	for (index = 0; ; index++) {
> +		lookup.index = index;
> +		lookup.n = 0;
> +		lookup.found = false;
> +
> +		INIT_LIST_HEAD(&res_list);
> +		ret = acpi_dev_get_resources(adev, &res_list, acpi_gpio_to_map,
> +					     &lookup);
> +		if (ret < 0)
> +			goto exit_free;
> +		acpi_dev_free_resource_list(&res_list);
> +		if (!lookup.found)
> +			break;
> +	}
> +
> +	*map = lookup.map;
> +	*num_maps = lookup.num_maps;
> +	*pctldevs = lookup.pctldevs;

This function has quite many stars in arguments and in the function
body. In particular pctldevs has three stars!

I wonder if this could be written in such way that avoids that. Like
create a structure holding the map information and pass that to the
function instead.

Other parts of the patch look good to me.