linux-kernel - Re: [PATCH 0/7] drivers/mfd: make max drivers explicitly non-modular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 4 Apr 2016 09:51:46 -0400
From:	Paul Gortmaker <paul.gortmaker@...driver.com>
To:	Lee Jones <lee.jones@...aro.org>
CC:	<linux-kernel@...r.kernel.org>,
	Chanwoo Choi <cw00.choi@...sung.com>,
	Haojian Zhuang <haojian.zhuang@...vell.com>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	MyungJoo Ham <myungjoo.ham@...sung.com>,
	Samuel Ortiz <sameo@...ux.intel.com>
Subject: Re: [PATCH 0/7] drivers/mfd: make max drivers explicitly non-modular

[Re: [PATCH 0/7] drivers/mfd: make max drivers explicitly non-modular] On 04/04/2016 (Mon 09:11) Lee Jones wrote:

> How did you come up with the subject lines for these patches?

I just used the general default of:
   <path_to_subsystem>: rest of subject

> 
> Please do `git log --oneline -- <subsystem>`, as is normal when
> submitting to mainline.

Just to be clear, looking at other mfd history, you want me to just
drop the "drivers/" prefix ; i.e. change from:

   drivers/mfd: text text text driver.c text

...to:

   mfd: text text text driver.c text

If so, that is no problem and I can do that for the next revision when I
drop the patches pending tristate conversion that I wasn't aware of.

Thanks,
Paul.
--

> 
> > For anyone new to the underlying goal of this cleanup, we are trying to
> > make driver code consistent with the Makefiles/Kconfigs that control them.
> > 
> > This means not using modular functions/macros for drivers that can never
> > be built as a module.  Some of the other downfalls this leads to are:
> > 
> >  (1) it is easy to accidentally write unused module_exit and remove code
> >  (2) it can be misleading when reading the source, thinking it can be
> >      modular when the Makefile and/or Kconfig prohibit it
> >  (3) it requires the include of the module.h header file which in turn
> >      includes nearly everything else, thus adding to CPP overhead.
> >  (4) it gets copied/replicated into other drivers and spreads like weeds.
> > 
> > There are quite a few in the mfd space, so rather than send a large
> > series, I'll try and batch them up into reasonable sized queues.  To that
> > end, here we fix up all the maxim drivers as the 1st mfd batch.
> > 
> > As always, the option exists for someone with the hardware and the desire
> > to extend the functionality to make any given driver tristate.  But given
> > the number of these tree wide and the fact that I can't test that new
> > extended functionality in all cases, I just make the code consistent with
> > the existing Kconfig/Makefile settings that restrict them to "bool".
> > 
> > Build tested on linux-next for arm, arm64 and x86-64 to ensure no typos
> > or similar issues crept in.
> > 
> > Paul.
> > ---
> > 
> > Cc: Chanwoo Choi <cw00.choi@...sung.com>
> > Cc: Haojian Zhuang <haojian.zhuang@...vell.com>
> > Cc: Krzysztof Kozlowski <k.kozlowski@...sung.com>
> > Cc: Kyungmin Park <kyungmin.park@...sung.com>
> > Cc: Lee Jones <lee.jones@...aro.org>
> > Cc: MyungJoo Ham <myungjoo.ham@...sung.com>
> > Cc: Samuel Ortiz <sameo@...ux.intel.com>
> > 
> > Paul Gortmaker (7):
> >   drivers/mfd: make max8925-i2c.c explicitly non-modular
> >   drivers/mfd: make max8997.c explicitly non-modular
> >   drivers/mfd: make max8998.c explicitly non-modular
> >   drivers/mfd: make max14577.c explicitly non-modular
> >   drivers/mfd: make max77686.c explicitly non-modular
> >   drivers/mfd: make max77693.c explicitly non-modular
> >   drivers/mfd: make max77843.c explicitly non-modular
> > 
> >  drivers/mfd/max14577.c    | 13 +------------
> >  drivers/mfd/max77686.c    | 26 ++------------------------
> >  drivers/mfd/max77693.c    | 34 +++-------------------------------
> >  drivers/mfd/max77843.c    | 24 ++----------------------
> >  drivers/mfd/max8925-i2c.c | 14 +-------------
> >  drivers/mfd/max8997.c     | 30 +++---------------------------
> >  drivers/mfd/max8998.c     | 27 +--------------------------
> >  7 files changed, 13 insertions(+), 155 deletions(-)
> > 
> 
> -- 
> Lee Jones
> Linaro STMicroelectronics Landing Team Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog