[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 4 Apr 2016 11:21:02 -0400
From: Javier Martinez Canillas <javier@....samsung.com>
To: Krzysztof Kozlowski <k.kozlowski@...sung.com>,
Paul Gortmaker <paul.gortmaker@...driver.com>,
linux-kernel@...r.kernel.org
Cc: Chanwoo Choi <cw00.choi@...sung.com>,
Samuel Ortiz <sameo@...ux.intel.com>,
Lee Jones <lee.jones@...aro.org>
Subject: Re: [PATCH 5/7] drivers/mfd: make max77686.c explicitly non-modular
Hello Krzysztof,
On 04/03/2016 11:44 PM, Krzysztof Kozlowski wrote:
> On 04.04.2016 06:24, Paul Gortmaker wrote:
>> The Kconfig currently controlling compilation of this code is:
>>
>> drivers/mfd/Kconfig:config MFD_MAX77686
>> drivers/mfd/Kconfig: bool "Maxim Semiconductor MAX77686/802 PMIC Support"
>>
>> ...meaning that it currently is not being built as a module by anyone.
>>
>> Lets remove the modular code that is essentially orphaned, so that
>> when reading the driver there is no doubt it is builtin-only.
>>
>> We explicitly disallow a driver unbind, since that doesn't have a
>> sensible use case anyway, and it allows us to drop the ".remove"
>> code for non-modular drivers.
>>
>> Since module_init was not in use by this code, the init ordering
>> remains unchanged with this commit.
>>
>> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
>>
>> We also delete the MODULE_LICENSE tag etc. since all that information
>> is already contained at the top of the file in the comments.
>>
>> Cc: Chanwoo Choi <cw00.choi@...sung.com>
>> Cc: Krzysztof Kozlowski <k.kozlowski@...sung.com>
>> Cc: Samuel Ortiz <sameo@...ux.intel.com>
>> Cc: Lee Jones <lee.jones@...aro.org>
>> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
>> ---
>> drivers/mfd/max77686.c | 26 ++------------------------
>> 1 file changed, 2 insertions(+), 24 deletions(-)
>
> +Cc Javier,
>
> I think we want to proceed with Javier's work for max77686:
> mfd: max77686: Allow the driver to be built as a module
> http://lkml.iu.edu/hypermail/linux/kernel/1602.1/03921.html
>
> Javier, what is the status of your patchset? What do you need?
>
All patches but the one getting rid of the subsys initcall were
already picked by Lee.
I was waiting for the exynos thermal [0] patch that adds probe
deferral support to land into mainline to resend that one. The
patch is already in mainline so I'll do it today after testing.
> Best regards,
> Krzysztof
>
[0]: https://lkml.org/lkml/2016/2/18/592
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
Powered by blists - more mailing lists