linux-kernel - Re: [PATCH 6/7] drivers/mfd: make max77693.c explicitly non-modular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 4 Apr 2016 11:39:28 -0400
From:	Paul Gortmaker <paul.gortmaker@...driver.com>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
CC:	<linux-kernel@...r.kernel.org>,
	Chanwoo Choi <cw00.choi@...sung.com>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Lee Jones <lee.jones@...aro.org>
Subject: Re: [PATCH 6/7] drivers/mfd: make max77693.c explicitly non-modular

[Re: [PATCH 6/7] drivers/mfd: make max77693.c explicitly non-modular] On 04/04/2016 (Mon 12:53) Krzysztof Kozlowski wrote:

> On 04.04.2016 06:24, Paul Gortmaker wrote:

[...]

> > diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c
> > index b83b7a7da1ae..4126a55269d2 100644
> > --- a/drivers/mfd/max77693.c
> > +++ b/drivers/mfd/max77693.c
> > @@ -2,7 +2,7 @@
> >   * max77693.c - mfd core driver for the MAX 77693
> >   *
> >   * Copyright (C) 2012 Samsung Electronics
> > - * SangYoung Son <hello.son@...sung.com>
> > + * SangYoung Son <hello.son@...sung.com>
> >   *
> 
> That's good change.

Do you wan't to simply fold the typo fix into your patch?  I don't need
to carry a trivial change like that as a separate patch, nor does it
warrant a "Reported-by" or anything like that.

Paul.
--

> 
> As for the rest, I think the driver can be switch to module. Consumer
> (phy-samsung-usb2) support deferred probing. I can prepare and test a
> patch for that.
> 
> Best regards,
> Krzysztof
> 
> >   * This program is not provided / owned by Maxim Integrated Products.
> >   *
> > @@ -23,7 +23,7 @@
> >   * This driver is based on max8997.c
> >   */
> >  
> > -#include <linux/module.h>
> > +#include <linux/init.h>
> >  #include <linux/slab.h>
> >  #include <linux/i2c.h>
> >  #include <linux/err.h>
> > @@ -309,28 +309,10 @@ err_i2c_haptic:
> >  	return ret;
> >  }
> >  
> > -static int max77693_i2c_remove(struct i2c_client *i2c)
> > -{
> > -	struct max77693_dev *max77693 = i2c_get_clientdata(i2c);
> > -
> > -	mfd_remove_devices(max77693->dev);
> > -
> > -	regmap_del_irq_chip(max77693->irq, max77693->irq_data_muic);
> > -	regmap_del_irq_chip(max77693->irq, max77693->irq_data_chg);
> > -	regmap_del_irq_chip(max77693->irq, max77693->irq_data_topsys);
> > -	regmap_del_irq_chip(max77693->irq, max77693->irq_data_led);
> > -
> > -	i2c_unregister_device(max77693->i2c_muic);
> > -	i2c_unregister_device(max77693->i2c_haptic);
> > -
> > -	return 0;
> > -}
> > -
> >  static const struct i2c_device_id max77693_i2c_id[] = {
> >  	{ "max77693", TYPE_MAX77693 },
> >  	{ }
> >  };
> > -MODULE_DEVICE_TABLE(i2c, max77693_i2c_id);
> >  
> >  static int max77693_suspend(struct device *dev)
> >  {
> > @@ -374,10 +356,10 @@ static struct i2c_driver max77693_i2c_driver = {
> >  	.driver = {
> >  		   .name = "max77693",
> >  		   .pm = &max77693_pm,
> > +		   .suppress_bind_attrs = true,
> >  		   .of_match_table = of_match_ptr(max77693_dt_match),
> >  	},
> >  	.probe = max77693_i2c_probe,
> > -	.remove = max77693_i2c_remove,
> >  	.id_table = max77693_i2c_id,
> >  };
> >  
> > @@ -387,13 +369,3 @@ static int __init max77693_i2c_init(void)
> >  }
> >  /* init early so consumer devices can complete system boot */
> >  subsys_initcall(max77693_i2c_init);
> > -
> > -static void __exit max77693_i2c_exit(void)
> > -{
> > -	i2c_del_driver(&max77693_i2c_driver);
> > -}
> > -module_exit(max77693_i2c_exit);
> > -
> > -MODULE_DESCRIPTION("MAXIM 77693 multi-function core driver");
> > -MODULE_AUTHOR("SangYoung, Son <hello.son@...sung.com>");
> > -MODULE_LICENSE("GPL");
> > 
>