[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 6 Jun 2016 16:40:36 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Mario Limonciello <mario_limonciello@...l.com>
Cc: hayeswang@...ltek.com, LKML <linux-kernel@...r.kernel.org>,
Netdev <netdev@...r.kernel.org>,
Linux USB <linux-usb@...r.kernel.org>, pali.rohar@...il.com,
anthony.wong@...onical.com, Greg KH <gregkh@...uxfoundation.org>
Subject: Re: [PATCH v3] r8152: Add support for setting pass through MAC
address on RTL8153-AD
> + /* returns _AUXMAC_#AABBCCDDEEFF# */
> + status = acpi_evaluate_object(NULL, "\\_SB.AMAC", NULL, &buffer);
> + obj = (union acpi_object *)buffer.pointer;
> + if (ACPI_SUCCESS(status)) {
> + if (obj->type != ACPI_TYPE_BUFFER ||
> + obj->string.length != 0x17) {
> + pr_warn("r8152: get_passthru_addr: Invalid buffer");
Please don't use pr_warn() when you can use the better alternatives
like dev_warn().
Andrew
Powered by blists - more mailing lists