linux-kernel - [PATCH] afs: remove redundant check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon,  6 Jun 2016 15:40:21 +0100
From:	Luis de Bethencourt <luisbg@....samsung.com>
To:	linux-kernel@...r.kernel.org
Cc:	linux-afs@...ts.infradead.org, dhowells@...hat.com,
	Luis de Bethencourt <luisbg@....samsung.com>
Subject: [PATCH] afs: remove redundant check

last is already checked before the switch statement, if it is false it will
return. A second check without the value possibly changing is redundant.

Signed-off-by: Luis de Bethencourt <luisbg@....samsung.com>
---
 fs/afs/cmservice.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/fs/afs/cmservice.c b/fs/afs/cmservice.c
index 4b0eff6..a201713 100644
--- a/fs/afs/cmservice.c
+++ b/fs/afs/cmservice.c
@@ -509,9 +509,6 @@ static int afs_deliver_cb_probe_uuid(struct afs_call *call, struct sk_buff *skb,
 		break;
 	}
 
-	if (!last)
-		return 0;
-
 	call->state = AFS_CALL_REPLYING;
 
 	INIT_WORK(&call->work, SRXAFSCB_ProbeUuid);
-- 
2.6.4