linux-kernel - Re: [PATCH] documentation: ntb.txt correct grammar "however"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 6 Jun 2016 14:56:26 -0400
From:	"Austin S. Hemmelgarn" <ahferroin7@...il.com>
To:	Ken Moffat <zarniwhoop@...world.com>,
	Justin Keller <justincompsci@...il.com>
Cc:	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] documentation: ntb.txt correct grammar "however"

On 2016-06-04 21:36, Ken Moffat wrote:
> On Sat, Jun 04, 2016 at 03:34:01PM -0400, Justin Keller wrote:
>> Correct the grammar around the word however.
>>
>> Signed-off-by: Justin Keller <justincompsci@...il.com>
>>
>> ---
>>
>> index 1d9bbab..5d43510 100644
>> --- a/Documentation/ntb.txt
>> +++ b/Documentation/ntb.txt
>> @@ -35,7 +35,7 @@ establishes a logical link to the peer, and creates queue pairs to exchange
>>  messages and data.  The NTB Netdev then creates an ethernet device using a
>>  Transport queue pair.  Network data is copied between socket buffers and the
>>  Transport queue pair buffer.  The Transport client may be used for other things
>> -besides Netdev, however no other applications have yet been written.
>> +besides Netdev; however, no other applications have yet been written.
>>
>>  ### NTB Ping Pong Test Client (ntb\_pingpong)
>
> As a user of British English, the original looks fine.  Your change,
> however, looks odd - a semi-colon seems out of place.  If you
> replaced it by a full-stop it would look acceptable to me - but not
> in any sense better than what is there at the moment.
FWIW, the existing usage in the file is common enough in at least 
British, American, and Australian English to be borderline idiomatic 
syntax, but is technically not correct based on traditional punctuation 
rules in any of them.

Personally, I'd leave it as is, especially considering that usage is 
also used by most translation services, and that proper usage of 
semicolons isn't taught much anymore even in collegiate English courses, 
so many younger individuals who speak English natively will think it 
looks odd.