linux-kernel - Re: [PATCH v2] HID: i2c-hid: set power sleep before shutdown

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 22 Jun 2016 19:15:51 +0800
From:	ghzhong <ghzhong@...angdigital.com>
To:	Jiri Kosina <jikos@...nel.org>
Cc:	Benjamin Tissoires <benjamin.tissoires@...hat.com>,
	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	Dmitry Torokhov <dtor@...omium.org>,
	Benson Leung <bleung@...omium.org>,
	Andrew Duggan <aduggan@...aptics.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] HID: i2c-hid: set power sleep before shutdown



On 06/21/2016 07:09 PM, Jiri Kosina wrote:
> On Tue, 21 Jun 2016, Guohua Zhong wrote:
>
>> Add i2c_hid_shutdown for i2c-hid driver to send suspend cmd & free
>> irq before device shutdown.
>>
>> Some HW design (i.e. Umaro, a chromebook model) is that the power to
>> i2c hid device won't down after device shutdown. Also the i2c-hid driver
>> do not send suspend cmd to the hid i2c device and free its irq before
>> shutdown.So if We touch the touchscreen or some other i2c hid device,
>> the power consumtion will be go up even when the device is in shutdown
>> state.
>>
>> Though the root cause maybe a HW issue. But it seems that it is a
>> good pratice to set power sleep for i2c-hid device before shutdown.
> Applied, thanks.
>
Do you mean that the Patch V2 has been reviewed & approved? Or I make something wrong and need  to do something else?